AlexYinHan commented on code in PR #26202:
URL: https://github.com/apache/flink/pull/26202#discussion_r1979208956
##########
flink-state-backends/flink-statebackend-forst/src/main/java/org/apache/flink/state/forst/ForStKeyedStateBackendBuilder.java:
##########
@@ -259,10 +259,14 @@ public ForStKeyedStateBackend<K> build() throws
BackendBuildingException {
defaultColumnFamilyHandle =
restoreResult.getDefaultColumnFamilyHandle();
nativeMetricMonitor = restoreResult.getNativeMetricMonitor();
- // TODO: init materializedSstFiles and lastCompletedCheckpointId
when implement restore
SortedMap<Long,
Collection<IncrementalKeyedStateHandle.HandleAndLocalPath>>
materializedSstFiles = new TreeMap<>();
long lastCompletedCheckpointId = -1L;
+ if (restoreOperation instanceof ForStIncrementalRestoreOperation) {
+ backendUID = restoreResult.getBackendUID();
+ materializedSstFiles = restoreResult.getRestoredSstFiles();
+ lastCompletedCheckpointId =
restoreResult.getLastCompletedCheckpointId();
+ }
Review Comment:
About only supporting the 1st ```FORWARD``` snapshot: Yeah i agree. The
thing is, if we inherit files as I am doing in this PR, we cannot use
```previousSnapshot.isEmpty()``` to determine whether the current snapshot is
the first one. I think we should determine whether at least one snapshot has
been completed using ```notifyCheckpointComplete```. I intended to put this
logic in a separate commit but somehow did not include it. Sorry for the
trouble. I will add this commit and then we can decide whether to keep the same
file inheritance approach as RocksDB.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
