Github user StephanEwen commented on a diff in the pull request:
https://github.com/apache/flink/pull/2917#discussion_r92625848
--- Diff:
flink-runtime/src/main/scala/org/apache/flink/runtime/akka/AkkaUtils.scala ---
@@ -216,12 +219,19 @@ object AkkaUtils {
* identified by hostname.
*
* @param configuration instance containing the user provided
configuration values
- * @param hostname of the network interface to listen on
+ * @param hostname of the network interface to bind on
* @param port to bind to or if 0 then Akka picks a free port
automatically
+ * @param externalHostname The host name to expect for Akka messages
+ * @param externalPort The port to expect for Akka messages
* @return Flink's Akka configuration for remote actor systems
*/
private def getRemoteAkkaConfig(configuration: Configuration,
- hostname: String, port: Int): Config = {
+ hostname: String, port: Int,
--- End diff --
Would be good to call `hostname` here `bind address`.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
