Github user StephanEwen commented on a diff in the pull request:
https://github.com/apache/flink/pull/2917#discussion_r92626387
--- Diff:
flink-runtime/src/main/scala/org/apache/flink/runtime/akka/AkkaUtils.scala ---
@@ -216,12 +219,19 @@ object AkkaUtils {
* identified by hostname.
*
* @param configuration instance containing the user provided
configuration values
- * @param hostname of the network interface to listen on
+ * @param hostname of the network interface to bind on
* @param port to bind to or if 0 then Akka picks a free port
automatically
+ * @param externalHostname The host name to expect for Akka messages
+ * @param externalPort The port to expect for Akka messages
* @return Flink's Akka configuration for remote actor systems
*/
private def getRemoteAkkaConfig(configuration: Configuration,
- hostname: String, port: Int): Config = {
+ hostname: String, port: Int,
+ externalHostname: String, externalPort:
Int): Config = {
+
+ LOG.info(s"Using binding address $hostname:$port" +
--- End diff --
Not too bad here, but in general, I think having loggers in util classes is
not a very good idea. It typically leads to the log lines showing up very often
and at strange places. The information should usually be logged by the caller
of the functions.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
