davidradl commented on code in PR #957:
URL: 
https://github.com/apache/flink-kubernetes-operator/pull/957#discussion_r2007926877


##########
flink-kubernetes-operator/src/test/java/org/apache/flink/kubernetes/operator/controller/FlinkDeploymentControllerTest.java:
##########
@@ -448,6 +465,15 @@ public void 
verifyUpgradeFromSavepointLegacyMode(FlinkVersion flinkVersion) thro
         assertEquals(
                 "savepoint_1", 
appCluster.getStatus().getJobStatus().getUpgradeSavepointPath());
 
+        // Validate status conditions

Review Comment:
   can we use a java parameterized test (or more than one as appropriate)  to 
cover all the permutations of the tests. 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to