bvarghese1 commented on code in PR #25753:
URL: https://github.com/apache/flink/pull/25753#discussion_r2012507962
##########
docs/content/docs/dev/table/sql/queries/over-agg.md:
##########
@@ -56,7 +56,7 @@ You can define multiple `OVER` window aggregates in a
`SELECT` clause. However,
### ORDER BY
-`OVER` windows are defined on an ordered sequence of rows. Since tables do not
have an inherent order, the `ORDER BY` clause is mandatory. For streaming
queries, Flink currently only supports `OVER` windows that are defined with an
ascending [time attributes]({{< ref "docs/dev/table/concepts/time_attributes"
>}}) order. Additional orderings are not supported.
+`OVER` windows are defined on an ordered sequence of rows. Since tables do not
have an inherent order, the `ORDER BY` clause is mandatory. For streaming
queries, Flink currently supports `OVER` windows that are defined with an
ascending [time attributes]({{< ref "docs/dev/table/concepts/time_attributes"
>}}) order or ascending non-time attributes. Additional orderings are not
supported.
Review Comment:
Fixed as suggested.
##########
docs/content/docs/dev/table/sql/queries/over-agg.md:
##########
@@ -70,11 +70,20 @@ There are two options to define the range, `ROWS` intervals
and `RANGE` interval
#### RANGE intervals
-A `RANGE` interval is defined on the values of the ORDER BY column, which is
in case of Flink always a time attribute. The following RANGE interval defines
that all rows with a time attribute of at most 30 minutes less than the current
row are included in the aggregate.
+A `RANGE` interval is defined on the values of the ORDER BY column, which is
in case of Flink is either a time or non-time attribute.
Review Comment:
Fixed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
