bvarghese1 commented on code in PR #25753:
URL: https://github.com/apache/flink/pull/25753#discussion_r2012508906
##########
flink-table/flink-table-planner/src/main/java/org/apache/flink/table/planner/plan/nodes/exec/stream/StreamExecOverAggregate.java:
##########
@@ -183,15 +190,15 @@ protected Transformation<RowData> translateToPlanInternal(
final int orderKey = orderKeys[0];
final LogicalType orderKeyType =
inputRowType.getFields().get(orderKey).getType();
- // check time field && identify window rowtime attribute
- final int rowTimeIdx;
+ // check time field && identify window time attribute
+ TimeAttribute timeAttribute;
if (isRowtimeAttribute(orderKeyType)) {
- rowTimeIdx = orderKey;
+ timeAttribute = TimeAttribute.ROW_TIME;
} else if (isProctimeAttribute(orderKeyType)) {
- rowTimeIdx = -1;
+ timeAttribute = TimeAttribute.PROC_TIME;
} else {
- throw new TableException(
- "OVER windows' ordering in stream mode must be defined on
a time attribute.");
+ timeAttribute = TimeAttribute.NON_TIME;
+ LOG.info("Non-time attribute window detected");
Review Comment:
Removed the extraneous log line
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
