nilmadhab commented on code in PR #26284:
URL: https://github.com/apache/flink/pull/26284#discussion_r2016683720
##########
flink-datastream-api/pom.xml:
##########
@@ -40,5 +40,11 @@ under the License.
<artifactId>flink-core-api</artifactId>
<version>${project.version}</version>
</dependency>
- </dependencies>
+ <dependency>
+ <groupId>org.apache.flink</groupId>
+ <artifactId>flink-core</artifactId>
Review Comment:
The dependency of `flink-core` module through using`TypeInformation` is only
used in the interfaces located in `flink-datastream-api`, as the
implementations are defined in `flink-datastream` module which are already
using `flink-core` module.
I think it does not make much sense to copy a large number of files and
maintain it just for a small feature and that too only for defining interfaces.
I am open to other ideas.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
