codenohup commented on code in PR #26284:
URL: https://github.com/apache/flink/pull/26284#discussion_r2020532374
##########
flink-datastream-api/pom.xml:
##########
@@ -40,5 +40,11 @@ under the License.
<artifactId>flink-core-api</artifactId>
<version>${project.version}</version>
</dependency>
- </dependencies>
+ <dependency>
+ <groupId>org.apache.flink</groupId>
+ <artifactId>flink-core</artifactId>
Review Comment:
> The dependency of `flink-core` module through using`TypeInformation` is
only used in the interfaces located in `flink-datastream-api`, as the
implementations are defined in `flink-datastream` module which are already
using `flink-core` module.
>
> I think it does not make much sense to copy a large number of files and
maintain it just for a small feature and that too only for defining interfaces.
I am open to other ideas.
Sorry for the delayed reply. I think we can introduce a class, such as
`TypeHint`, at the API level that allows users to define a class with generics.
Subsequently, this `TypeHint` can be converted into `TypeInformation` at the
implementation level.
During this process, you can leverage `TypeDescriptor` to describe common
types within the `flink-datastream-api`. Additionally, it would be advantageous
to incorporate the `tuple` type into `TypeDescriptor`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
