davidradl commented on code in PR #26385: URL: https://github.com/apache/flink/pull/26385#discussion_r2022473816
########## docs/content.zh/docs/dev/python/table/table_environment.md: ########## @@ -199,6 +199,50 @@ TableEnvironment API {{< pythondoc file="pyflink.table.html#pyflink.table.TableEnvironment.drop_table" name="link">}} </td> </tr> + <tr> + <td> + <strong>create_model(model_path, model_descriptor, ignore_if_exists=False)</strong> + </td> + <td> + Registers a `Model` object as a model similar to SQL Models. Review Comment: It would be useful to define or link to what we mean by this Model compared the SQL model. Registering a model as a model, is not too helpful text, can a model be registered not as a model? Maybe mention the model path and descriptor. I think we should say create not registering in the comments to match the method name. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org