davidradl commented on code in PR #26385:
URL: https://github.com/apache/flink/pull/26385#discussion_r2022510847


##########
flink-python/pyflink/table/table_environment.py:
##########
@@ -656,6 +657,47 @@ def list_temporary_views(self) -> List[str]:
         j_view_name_array = self._j_tenv.listTemporaryViews()
         return [item for item in j_view_name_array]
 
+    def list_models(self) -> List[str]:
+        """
+        Gets the names of all model available in the current namespace (the 
current
+        database of the current catalog).
+
+        :return: A list of the names of all registered models in the current 
database
+                 of the current catalog.
+
+        .. versionadded:: 2.0.1
+        """
+        j_model_name_array = self._j_tenv.listModels()
+        return [item for item in j_model_name_array]
+
+    def list_models(self, catalog_name: str, database_name: str) -> List[str]:
+        """
+        Gets the names of all model available in the provided namespace (the 
provided
+        database of the provided catalog).
+
+        :param catalog_name: The name of catalog to list models from.
+        :param database_name: The name of database to list models from
+        :return: A list of the names of all registered models in the current 
database

Review Comment:
   nit: no need for the word current here 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to