lincoln-lil commented on code in PR #26390:
URL: https://github.com/apache/flink/pull/26390#discussion_r2026622510
##########
flink-table/flink-table-api-java/src/main/java/org/apache/flink/table/planner/loader/PlannerModule.java:
##########
@@ -72,6 +72,7 @@ public class PlannerModule {
"org.codehaus.commons",
"org.apache.commons.lang3",
"org.apache.commons.math3",
+ "org.apache.commons.text",
Review Comment:
Coincidentally, we've also run into this problem, would it be more flexible
to reuse flink conf here to make it configurable(read
`CoreOptions.ALWAYS_PARENT_FIRST_LOADER_PATTERNS_ADDITIONAL`)?
FYI my fix in the PlannerModule's constructor:
```
final Configuration conf =
GlobalConfiguration.loadConfiguration();
final String[] ownerClasspath =
Stream.concat(
Stream.concat(
Arrays.stream(
CoreOptions.PARENT_FIRST_LOGGING_PATTERNS),
Stream.of(
// These packages are
shipped either by
// flink-table-runtime
or flink-dist itself
"org.codehaus.janino",
"org.codehaus.commons",
"org.apache.commons.lang3",
"org.apache.commons.math3",
"org.apache.commons.text")),
// Also can be configured by
//
ALWAYS_PARENT_FIRST_LOADER_PATTERNS_ADDITIONAL
conf
.get(
CoreOptions
.ALWAYS_PARENT_FIRST_LOADER_PATTERNS_ADDITIONAL)
.stream())
.toArray(String[]::new);
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
