AHeise commented on code in PR #26390:
URL: https://github.com/apache/flink/pull/26390#discussion_r2027374907


##########
flink-table/flink-table-api-java/src/main/java/org/apache/flink/table/planner/loader/PlannerModule.java:
##########
@@ -72,6 +72,7 @@ public class PlannerModule {
                                     "org.codehaus.commons",
                                     "org.apache.commons.lang3",
                                     "org.apache.commons.math3",
+                                    "org.apache.commons.text",

Review Comment:
   I think there is something fundamentally wrong with having class loader 
exceptions at this point. We are not loading user code here, right? I must 
admit that I'm just starting to look at the planner.
   
   I'd like to take a closer look at this before we add any new configuration. 
For example, maybe the list of exceptions should be annotated in the module and 
used here. Maybe we don't need exceptions at all and we just need to use a 
different class loading order.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to