davidradl commented on code in PR #26361:
URL: https://github.com/apache/flink/pull/26361#discussion_r2026929581
##########
flink-table/flink-table-planner/src/test/java/org/apache/flink/table/planner/plan/nodes/exec/serde/DynamicTableSinkSpecSerdeTest.java:
##########
@@ -173,7 +174,36 @@ static Stream<DynamicTableSinkSpec>
testDynamicTableSinkSpecSerde() {
RowType.of(new BigIntType(), new
IntType()))),
null);
- return Stream.of(spec1, spec2, spec3);
+ Map<String, String> options4 = new HashMap<>();
+ options4.put("connector", TestValuesTableFactory.IDENTIFIER);
+ int[][] targetColumnIndices = new int[][] {{0}, {1}};
+
+ final ResolvedSchema resolvedSchema4 =
+ new ResolvedSchema(
+ Arrays.asList(
+ Column.physical("a", DataTypes.BIGINT()),
Review Comment:
Could we have a more complex schema in the test? I suggest including maps,
nesting with objects and nested arrays, and arrays of objects.
I am curious if writing nulls to nullable columns is a consideration here;
if so maybe a test to ensure that works?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
