davidradl commented on code in PR #26415:
URL: https://github.com/apache/flink/pull/26415#discussion_r2033074588
##########
flink-state-backends/flink-statebackend-forst/src/main/java/org/apache/flink/state/forst/fs/cache/CachedDataInputStream.java:
##########
@@ -102,15 +102,17 @@ private FSDataInputStream getStream() throws IOException {
if (isFlinkThread()) {
cacheEntry.touch();
}
- FSDataInputStream stream = tryGetCacheStream();
- if (stream != null) {
- fileBasedCache.incHitCounter();
- return stream;
- }
-
- if (streamStatus == StreamStatus.CACHED_CLOSED
- || streamStatus == StreamStatus.CACHED_CLOSING) {
+ // Repeat until get a stream
+ while (true) {
Review Comment:
nit: this is just a suggestion - so feel free to ignore.
I would have the
```
FSDataInputStream stream = tryGetCacheStream();
while (stream == null) {
....
}
return stream;
```
Assign originalString to stream when you want to return it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
