davidradl commented on code in PR #26415:
URL: https://github.com/apache/flink/pull/26415#discussion_r2033088651
##########
flink-state-backends/flink-statebackend-forst/src/main/java/org/apache/flink/state/forst/fs/cache/CachedDataInputStream.java:
##########
@@ -125,39 +127,53 @@ private FSDataInputStream getStream() throws IOException {
StreamStatus.CACHED_CLOSED);
streamStatus = StreamStatus.CACHED_CLOSED;
}
- // try reopen
- tryReopen();
- stream = tryGetCacheStream();
- if (stream != null) {
- fileBasedCache.incHitCounter();
- return stream;
- }
- fileBasedCache.incMissCounter();
- return originalStream;
- } else if (streamStatus == StreamStatus.ORIGINAL) {
- fileBasedCache.incMissCounter();
- return originalStream;
- } else {
- if (streamStatus == StreamStatus.CACHED_OPEN) {
- stream = tryGetCacheStream();
+ // if it is CACHED_CLOSED, we try to reopen it
+ if (streamStatus == StreamStatus.CACHED_CLOSED) {
+ stream = tryReopen();
Review Comment:
nit: tryReopen -> tryReopenCacheStream
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
