davidradl commented on code in PR #26426:
URL: https://github.com/apache/flink/pull/26426#discussion_r2034833651
##########
flink-core/src/main/java/org/apache/flink/configuration/Configuration.java:
##########
@@ -239,9 +239,21 @@ public void addAllToProperties(Properties props) {
}
public void addAll(Configuration other) {
- synchronized (this.confData) {
Review Comment:
I am not totally convinced there are no issues with this locking strategy.
If we have 2 configuration object A and B, they would always lock the other
then ourselves. From object A's and B's perspective the lock order is not
always the same.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
