hlteoh37 commented on code in PR #26274:
URL: https://github.com/apache/flink/pull/26274#discussion_r2031598336
##########
flink-connectors/flink-connector-base/src/main/java/org/apache/flink/connector/base/sink/writer/BufferedRequestState.java:
##########
@@ -39,13 +38,13 @@ public class BufferedRequestState<RequestEntryT extends
Serializable> implements
private final List<RequestEntryWrapper<RequestEntryT>>
bufferedRequestEntries;
private final long stateSize;
- public BufferedRequestState(Deque<RequestEntryWrapper<RequestEntryT>>
bufferedRequestEntries) {
+ public BufferedRequestState(List<RequestEntryWrapper<RequestEntryT>>
bufferedRequestEntries) {
this.bufferedRequestEntries = new ArrayList<>(bufferedRequestEntries);
this.stateSize = calculateStateSize();
}
- public BufferedRequestState(List<RequestEntryWrapper<RequestEntryT>>
bufferedRequestEntries) {
- this.bufferedRequestEntries = new ArrayList<>(bufferedRequestEntries);
+ public BufferedRequestState(RequestBuffer<RequestEntryT> requestBuffer) {
+ this.bufferedRequestEntries = new
ArrayList<>(requestBuffer.getBufferedState());
Review Comment:
Ah no what I mean here is simply that this is a class with `@PublicEvolving`
so we shouldn't be making any breaking changes to public methods (e.g. we
should only be adding public constructors, and can't be removing any. (Your
change is removing a constructor signature for
`BufferedRequestState(Deque<RequestEntryWrapper<RequestEntryT>>
bufferedRequestEntries)`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
