Poorvankbhatia commented on code in PR #26274:
URL: https://github.com/apache/flink/pull/26274#discussion_r2028584512
##########
flink-connectors/flink-connector-base/src/main/java/org/apache/flink/connector/base/sink/writer/AsyncSinkWriter.java:
##########
@@ -545,4 +550,14 @@ public void timeout() {
}
}
}
+
+ @VisibleForTesting
+ RequestBuffer<RequestEntryT> getBufferedRequestEntries() {
+ return bufferedRequestEntries;
+ }
+
+ @VisibleForTesting
+ BatchCreator<RequestEntryT> getBatchCreator() {
+ return batchCreator;
+ }
Review Comment:
Removed these methods and added a new function in AsyncSinkWriterImpl within
the AsyncSinkWriterTest that takes in `batchCreator` and `requestBuffer` and
used that for testing.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
