lihaosky commented on code in PR #26528:
URL: https://github.com/apache/flink/pull/26528#discussion_r2077932178
##########
flink-table/flink-table-planner/src/main/java/org/apache/flink/table/planner/operations/converters/SqlNodeConverters.java:
##########
@@ -53,6 +53,7 @@ public class SqlNodeConverters {
register(new SqlTruncateTableConverter());
register(new SqlShowFunctionsConverter());
register(new SqlShowModelsConverter());
+ register(new SqlShowCreateModelConverter());
Review Comment:
It's not using this pattern:
https://github.com/apache/flink/blob/master/flink-table/flink-table-planner/src/main/java/org/apache/flink/table/planner/operations/SqlNodeToOperationConversion.java#L322
The converters pattern is introduced after table operations added. There can
be followups to migration table operations to converters maybe
##########
flink-table/flink-table-planner/src/test/scala/org/apache/flink/table/api/TableEnvironmentTest.scala:
##########
@@ -2957,6 +2957,136 @@ class TableEnvironmentTest {
checkData(expectedResult1.iterator(), modelResult2.collect())
}
+ @Test
Review Comment:
Sure I'll add more types
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
