lihaosky commented on code in PR #26528:
URL: https://github.com/apache/flink/pull/26528#discussion_r2085179230


##########
flink-table/flink-table-api-java/src/main/java/org/apache/flink/table/api/internal/ShowCreateUtil.java:
##########
@@ -177,6 +206,17 @@ static String 
extractFormattedColumns(ResolvedCatalogBaseTable<?> table, String
                 .collect(Collectors.joining(",\n"));
     }
 
+    static Optional<String> extractFormattedColumns(ResolvedSchema schema) {

Review Comment:
   This is formatted differently from table. In table, each column is a row 
(joined by `\n'). In model, columns for `input` and `output` are in same row 
respectively (joined by `,`). I feel it's ok since the input/output columns for 
model won't be too many. wdyt?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to