lajith2006 commented on PR #957:
URL: 
https://github.com/apache/flink-kubernetes-operator/pull/957#issuecomment-2904893544

   > Would it be useful also to set also observedGeneration on the conditions, 
I believe it is in general a good practice.
   
   by looking into some docs, It seems like condition offers a meaningful 
status info if the cond.observedGeneration is same as  metadata.generation, 
provided condition is calculated based on the last configuration of the object. 
So in our case here , as condition represents the different status of job, not 
sure if we have cond.observedGeneration, that  will matches with 
metadata.generation. WDYT?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to