davidradl commented on PR #957:
URL:
https://github.com/apache/flink-kubernetes-operator/pull/957#issuecomment-2934354663
@gyfora a quick update, @lajith2006 is working on the code. With his testing
he found that we could not rely on the jobStatus to determine whether the mode
was application or cluster, as we see cluster cases with values in jobStatus.
The 2 things I have asked for are :
- we use the last reconciled spec to find out the mode. This is existing
code in Mode.java that has this enum and uses this logic. I suggested moving
the enum so we can access it and amend the current deployment caller to the
existing Mode.java.
- if we only every have one condition we should store an condition object
internally not a list. Then construct the list of conditions from the presence
of absence of the condition object in the getConditions method we added.
I am just checking - are you ok with my suggestions. The condition logic
will be out of the status class -as per your suggestion.
@klam-shop as you can see we have a couple of nits , but hope to get this
merged soon.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
