pnowojski commented on code in PR #26619:
URL: https://github.com/apache/flink/pull/26619#discussion_r2115854495
##########
flink-tests/src/test/java/org/apache/flink/test/streaming/runtime/SinkV2ITCase.java:
##########
@@ -111,12 +114,13 @@ public void writerAndCommitterExecuteInStreamingMode()
throws Exception {
final Source<Integer, ?, ?> source = createStreamingSource();
env.fromSource(source, WatermarkStrategy.noWatermarks(), "source")
+ .rebalance()
Review Comment:
Can you add comment why `rebalance()` is important here? (that we want to
assert unaligned checkpoints are enabled on the `source -> writer` edge?
Speaking of, probably it would be better to replace `rebalance()` with some
`keyBy`, as AFAIR technically speaking `rebalance()` also doesn't support UC,
but for other reasons?
ditto other places
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
