1996fanrui commented on code in PR #26619:
URL: https://github.com/apache/flink/pull/26619#discussion_r2116001670
##########
flink-tests/src/test/java/org/apache/flink/test/streaming/runtime/SinkV2ITCase.java:
##########
@@ -111,12 +114,13 @@ public void writerAndCommitterExecuteInStreamingMode()
throws Exception {
final Source<Integer, ?, ?> source = createStreamingSource();
env.fromSource(source, WatermarkStrategy.noWatermarks(), "source")
+ .rebalance()
Review Comment:
> that we want to assert unaligned checkpoints are enabled on the source ->
writer edge?
Exactly
> Speaking of, probably it would be better to replace rebalance() with some
keyBy, as AFAIR technically speaking rebalance() also doesn't support UC, but
for other reasons?
Sorry, I don't understand why rebalance doesn't support unaligned
checkpoint? From the code of
StreamPartitioner#isSupportsUnalignedCheckpoint[1], RebalancePartitioner is not
Pointwise and Broadcast, so I think rebalance support unaligned checkpoint. Did
I miss anything?
Also, I updated some of `rebalance`s to `keyBy`, it could cover more cases.
[1]
https://github.com/apache/flink/blob/c9a3459530b56cef2f50ece215367ba7ff1403e8/flink-runtime/src/main/java/org/apache/flink/streaming/runtime/partitioner/StreamPartitioner.java#L89
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
