[ 
https://issues.apache.org/jira/browse/FLINK-5280?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15795541#comment-15795541
 ] 

ASF GitHub Bot commented on FLINK-5280:
---------------------------------------

Github user mushketyk commented on the issue:

    https://github.com/apache/flink/pull/3039
  
    Hi @wuchong 
    
    >> And provide three other abstract class : BatchTableSource (with 
getDataSet interface) , StreamTableSource (with getDataStream interface) and 
BatchStreamTableSource (with both interfaces), they all extend TableSource
    
    I thought about this, but in this case we won't be able to use an instance 
of `BatchStreamTableSource` where an instance of  `BatchTableSource` or  
`StreamTableSource` is expected. Which seems to make `BatchStreamTableSource` 
abstract class useless.
    
    I believe that we should be able to use `BatchStreamTableSource` where 
either `TableSource`, `BatchTableSource` or `StreamTableSource` is expected and 
this requires to use multiple inheritance which is only possible with traits. 
But since we want to provide partial implementations of these types I've add 
several abstract class for users to inherit from.
    
    I see the issue with current approach, but I am not sure how to simplify it 
to achieve all required goals. Would better documentation do the trick?


> Extend TableSource to support nested data
> -----------------------------------------
>
>                 Key: FLINK-5280
>                 URL: https://issues.apache.org/jira/browse/FLINK-5280
>             Project: Flink
>          Issue Type: Improvement
>          Components: Table API & SQL
>    Affects Versions: 1.2.0
>            Reporter: Fabian Hueske
>            Assignee: Ivan Mushketyk
>
> The {{TableSource}} interface does currently only support the definition of 
> flat rows. 
> However, there are several storage formats for nested data that should be 
> supported such as Avro, Json, Parquet, and Orc. The Table API and SQL can 
> also natively handle nested rows.
> The {{TableSource}} interface and the code to register table sources in 
> Calcite's schema need to be extended to support nested data.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to