[ 
https://issues.apache.org/jira/browse/FLINK-5280?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15802705#comment-15802705
 ] 

ASF GitHub Bot commented on FLINK-5280:
---------------------------------------

Github user fhueske commented on a diff in the pull request:

    https://github.com/apache/flink/pull/3039#discussion_r94856759
  
    --- Diff: 
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/plan/nodes/FlinkRel.scala
 ---
    @@ -120,6 +124,7 @@ trait FlinkRel {
             case typeName if 
SqlTypeName.YEAR_INTERVAL_TYPES.contains(typeName) => s + 8
             case typeName if SqlTypeName.DAY_INTERVAL_TYPES.contains(typeName) 
=> s + 4
             case SqlTypeName.TIME | SqlTypeName.TIMESTAMP | SqlTypeName.DATE 
=> s + 12
    +        case SqlTypeName.ROW => s + 
estimateRowSize(fieldList.get(0).getType()).asInstanceOf[Int]
    --- End diff --
    
    shouldn't `get(0)` access the type at the index of the current field that 
is folded instead of always the first?


> Extend TableSource to support nested data
> -----------------------------------------
>
>                 Key: FLINK-5280
>                 URL: https://issues.apache.org/jira/browse/FLINK-5280
>             Project: Flink
>          Issue Type: Improvement
>          Components: Table API & SQL
>    Affects Versions: 1.2.0
>            Reporter: Fabian Hueske
>            Assignee: Ivan Mushketyk
>
> The {{TableSource}} interface does currently only support the definition of 
> flat rows. 
> However, there are several storage formats for nested data that should be 
> supported such as Avro, Json, Parquet, and Orc. The Table API and SQL can 
> also natively handle nested rows.
> The {{TableSource}} interface and the code to register table sources in 
> Calcite's schema need to be extended to support nested data.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to