morozov commented on code in PR #3666:
URL: https://github.com/apache/flink-cdc/pull/3666#discussion_r2129381175
##########
flink-cdc-connect/flink-cdc-source-connectors/flink-connector-mysql-cdc/src/main/java/io/debezium/connector/mysql/MySqlConnection.java:
##########
@@ -90,6 +95,41 @@ public MySqlConnection(
this.connectionConfig = connectionConfig;
this.mysqlFieldReader = fieldReader;
this.urlPattern = connectionConfig.getUrlPattern();
+
+ probeShowBinaryLogStatement();
Review Comment:
This method both returns the result of the probe and stores it in a
property, which isn't nice from the CQRS standpoint (a method should either
return a value or produce side effects, but not both).
Would it make sense to split it into `probe()` and `get()`? The constructor
would call `probe()` and store the result in a property, and `get()` would
return the property. In this case, the field can be made final.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
