morozov commented on PR #3666: URL: https://github.com/apache/flink-cdc/pull/3666#issuecomment-2946141273
Correct me if I'm wrong, but it looks like using the proper SQL command for showing binary logs is the only major change here. The rest is about refactoring the test suite. @leonardBang is the support for binlog compression a blocker for these changes to get merged? > [...] needs more discussion and testing over this. @yuxiqian do you have any specific discussion topics in mind? As for testing, I believe having the test suite pass would be a great start, although it's not clear why the CI didn't run the tests on this PR. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
