snuyanzin commented on code in PR #26643:
URL: https://github.com/apache/flink/pull/26643#discussion_r2132201682


##########
flink-table/flink-table-planner/src/test/java/org/apache/flink/table/planner/plan/nodes/exec/common/JoinTestPrograms.java:
##########
@@ -472,28 +472,27 @@ public class JoinTestPrograms {
                         .setupTableSource(
                                 SourceTestStep.newBuilder("source_t1")
                                         .addSchema("a INTEGER", "b BIGINT", "c 
STRING")
-                                        .producedBeforeRestore(Row.of(1, 2L, 
"3"))
-                                        .producedAfterRestore(Row.of(12, 34L, 
"56"))
+                                        .producedBeforeRestore(
+                                                Row.of(1, 2L, "3"), Row.of(12, 
34L, "56"))
                                         .build())
                         .setupTableSource(
                                 SourceTestStep.newBuilder("source_t2")
                                         .addSchema("d INTEGER", "e BIGINT", "f 
STRING")
-                                        .producedBeforeRestore(Row.of(1, 2L, 
"3"))
-                                        .producedAfterRestore(Row.of(11, 22L, 
"33"))
+                                        .producedBeforeRestore(
+                                                Row.of(1, 2L, "3"), Row.of(11, 
22L, "33"))
                                         .build())
                         .setupTableSource(
                                 SourceTestStep.newBuilder("source_t3")
                                         .addSchema("i INTEGER", "j BIGINT", "k 
STRING")
-                                        .producedBeforeRestore(Row.of(1, 2L, 
"3"))
-                                        .producedAfterRestore(Row.of(111, 
222L, "333"))
+                                        .producedBeforeRestore(
+                                                Row.of(1, 2L, "3"), 
Row.of(111, 222L, "333"))
                                         .build())
                         .setupTableSink(
                                 SinkTestStep.newBuilder("sink_t")
                                         .addSchema("b BIGINT")
-                                        .consumedBeforeRestore("+I[2]")
-                                        .consumedAfterRestore(
-                                                "-D[2]", "+I[2]", "+I[34]", 
"-D[2]", "-D[34]",
-                                                "+I[2]", "+I[34]")
+                                        .consumedBeforeRestore(
+                                                "+I[2]", "+I[34]", "-D[2]", 
"-D[34]", "+I[2]",
+                                                "+I[34]")

Review Comment:
           step1: 1 (a), 2 (b), 3 (c)  in source_t1  // CASE returns 1, NOT IN 
returns true
           +I[2]
           step2: 12 (a), 34 (b), 56 (c) in source_t1  // CASE returns 1, NOT 
IN returns true
           +I[34]
           step3: 1 (d), 2 (e), 3 (f)  in source_t2 // CASE returns 1, NOT IN 
returns false
           -D[2]
           -D[34]
           step3: 1 (i), 2 (j), 3 (k)  in source_t3 // CASE returns 2, NOT IN 
returns true
           +I[2]
           +I[34]



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to