lincoln-lil commented on PR #26648: URL: https://github.com/apache/flink/pull/26648#issuecomment-2955640770
@xuyangzhong Before going into the code details, could you explain more about the semantics of this new trait? IIUC, you want to describe the requirements of the operator for the input, that whether it can include duplicate changes. In terms of trait naming, `DuplicateChanges` lacks a description of the propagation direction, because here we are trying to explain the requirements of the operator on its input (or, in other words, the requirements of downstream operators on upstream's output). From this perspective, `AllowDuplicateChanges` might be clearer? From the perspective of the values, I don't see the necessity of introducing four values. `UNKNOWN` seems redundant. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
