xuyangzhong commented on code in PR #26648: URL: https://github.com/apache/flink/pull/26648#discussion_r2139267625
########## flink-table/flink-table-planner/src/main/scala/org/apache/flink/table/planner/plan/optimize/RelNodeBlock.scala: ########## @@ -139,6 +141,16 @@ class RelNodeBlock(val outputNode: RelNode) { def getMiniBatchInterval: MiniBatchInterval = miniBatchInterval + def setAllowDuplicateChanges(allowDuplicateChanges: Boolean): Unit = { + // a child block may have multiple parents (outputs), if one of the parents could not + // accept duplicated changes, then this child block doesn't allow to produce duplicate changes + if (this.allowDuplicateChanges) { + this.allowDuplicateChanges = allowDuplicateChanges + } + } + + def isAllowDuplicateChanges: Boolean = allowDuplicateChanges Review Comment: The variable is already named as `allowDuplicateChanges`... I decide to rename this method to `isDuplicateChangesAllowed`. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org