snuyanzin commented on code in PR #26704: URL: https://github.com/apache/flink/pull/26704#discussion_r2157631486
########## flink-table/flink-table-planner/src/test/java/org/apache/flink/table/planner/functions/StructuredFunctionsITCase.java: ########## @@ -88,14 +97,60 @@ Stream<TestSetSpec> getTestSetSpecs() { DataTypes.BOOLEAN())); } + private static @NotNull Stream<TestSetSpec> objectOfTestCases() { + return Stream.of( + TestSetSpec.forFunction(BuiltInFunctionDefinitions.OBJECT_OF) + .onFieldsWithData(42, "Bob") + .andDataTypes(DataTypes.INT(), DataTypes.STRING()) + .withFunction(Type1.Type1Constructor.class) + .withFunction(Type2.Type2Constructor.class) + .withFunction(NestedType.NestedConstructor.class) + // Test with OBJECT_OF + .testResult( + objectOf(Type1.class, "a", 42, "b", "Bob"), + "OBJECT_OF('" + Type1.class.getName() + "', 'a', 42, 'b', 'Bob')", Review Comment: seems subquery not supported (not sure if it is related to this PR) this is ok ```sql SELECT OBJECT_OF('<class_name>', 'f0', 1); ``` this was not able to success ```sql SELECT OBJECT_OF('<class_name>', 'f0', (SELECT 1)); ``` or did I miss anything? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org