davidradl commented on code in PR #26802:
URL: https://github.com/apache/flink/pull/26802#discussion_r2210873321
##########
flink-table/flink-table-common/src/test/java/org/apache/flink/table/types/ValueDataTypeConverterTest.java:
##########
@@ -60,6 +60,9 @@ private static Stream<Arguments> testData() {
of(new BigDecimal("12.123"), DataTypes.DECIMAL(5, 3)),
of(new BigDecimal("1E+36"), DataTypes.DECIMAL(37, 0)),
of(new BigDecimal("0.000"), DataTypes.DECIMAL(4, 3)),
+ of(new BigDecimal("0.0"), DataTypes.DECIMAL(2, 1)),
+ of(new BigDecimal("0.11"), DataTypes.DECIMAL(3, 2)),
+ of(new BigDecimal("0.011"), DataTypes.DECIMAL(4, 3)),
Review Comment:
Can we test ` 0000.01` and `.01` please. We may need to normalize the zero's
to the left of the decimal point to one zero. WDYT?
Also can we test where there is a scale of 38, so when we add one we go over
the maximum precision size.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
