fapaul commented on code in PR #26802:
URL: https://github.com/apache/flink/pull/26802#discussion_r2212446505
##########
flink-table/flink-table-common/src/test/java/org/apache/flink/table/types/ValueDataTypeConverterTest.java:
##########
@@ -60,6 +60,9 @@ private static Stream<Arguments> testData() {
of(new BigDecimal("12.123"), DataTypes.DECIMAL(5, 3)),
of(new BigDecimal("1E+36"), DataTypes.DECIMAL(37, 0)),
of(new BigDecimal("0.000"), DataTypes.DECIMAL(4, 3)),
+ of(new BigDecimal("0.0"), DataTypes.DECIMAL(2, 1)),
+ of(new BigDecimal("0.11"), DataTypes.DECIMAL(3, 2)),
+ of(new BigDecimal("0.011"), DataTypes.DECIMAL(4, 3)),
Review Comment:
I am okay handling the scale above 38 as a follow-up since it's unrelated to
the original issue that the PR wants to fix.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
