snuyanzin commented on code in PR #26856:
URL: https://github.com/apache/flink/pull/26856#discussion_r2246388586
##########
flink-table/flink-table-planner/src/test/resources/restore-tests/stream-exec-multi-join_1/four-way-complex-updating-join-with-restore/plan/four-way-complex-updating-join-with-restore.json:
##########
@@ -103,22 +103,31 @@
}
}
}
- }
+ },
+ "abilities" : [ {
+ "type" : "ProjectPushDown",
+ "projectedFields" : [ [ 0 ], [ 2 ] ],
+ "producedType" : "ROW<`order_id` VARCHAR(2147483647) NOT NULL,
`user_id_1` VARCHAR(2147483647)> NOT NULL"
+ }, {
+ "type" : "ReadingMetadata",
+ "metadataKeys" : [ ],
+ "producedType" : "ROW<`order_id` VARCHAR(2147483647) NOT NULL,
`user_id_1` VARCHAR(2147483647)> NOT NULL"
+ } ]
},
- "outputType" : "ROW<`order_id` VARCHAR(2147483647) NOT NULL, `product`
VARCHAR(2147483647), `user_id_1` VARCHAR(2147483647)>",
- "description" : "TableSourceScan(table=[[default_catalog,
default_database, Orders]], fields=[order_id, product, user_id_1])"
+ "outputType" : "ROW<`order_id` VARCHAR(2147483647) NOT NULL, `user_id_1`
VARCHAR(2147483647)>",
+ "description" : "TableSourceScan(table=[[default_catalog,
default_database, Orders, project=[order_id, user_id_1], metadata=[]]],
fields=[order_id, user_id_1])"
Review Comment:
ideally yes, however it should still able to read old plans with empty arrays
##########
flink-table/flink-table-planner/src/test/resources/restore-tests/stream-exec-multi-join_1/four-way-complex-updating-join-with-restore/plan/four-way-complex-updating-join-with-restore.json:
##########
@@ -103,22 +103,31 @@
}
}
}
- }
+ },
+ "abilities" : [ {
+ "type" : "ProjectPushDown",
+ "projectedFields" : [ [ 0 ], [ 2 ] ],
+ "producedType" : "ROW<`order_id` VARCHAR(2147483647) NOT NULL,
`user_id_1` VARCHAR(2147483647)> NOT NULL"
+ }, {
+ "type" : "ReadingMetadata",
+ "metadataKeys" : [ ],
+ "producedType" : "ROW<`order_id` VARCHAR(2147483647) NOT NULL,
`user_id_1` VARCHAR(2147483647)> NOT NULL"
+ } ]
},
- "outputType" : "ROW<`order_id` VARCHAR(2147483647) NOT NULL, `product`
VARCHAR(2147483647), `user_id_1` VARCHAR(2147483647)>",
- "description" : "TableSourceScan(table=[[default_catalog,
default_database, Orders]], fields=[order_id, product, user_id_1])"
+ "outputType" : "ROW<`order_id` VARCHAR(2147483647) NOT NULL, `user_id_1`
VARCHAR(2147483647)>",
+ "description" : "TableSourceScan(table=[[default_catalog,
default_database, Orders, project=[order_id, user_id_1], metadata=[]]],
fields=[order_id, user_id_1])"
Review Comment:
ideally yes, however it should still be able to read old plans with empty
arrays
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
