twalthr commented on code in PR #26893:
URL: https://github.com/apache/flink/pull/26893#discussion_r2269989301


##########
flink-table/flink-table-planner/src/test/java/org/apache/flink/table/planner/runtime/stream/sql/DataStreamJavaITCase.java:
##########
@@ -531,6 +531,8 @@ void testFromChangelogStreamUpsert() {
                         output(RowKind.INSERT, "alice", 1),
                         // --
                         input(RowKind.INSERT, "alice", 1), // no impact
+                        input(RowKind.UPDATE_AFTER, "alice", 1), // no impact

Review Comment:
   Could we add a `ChangelogNormalizeSematicTests` similar to 
`SinkSemanticTests`? This location is actually meant for testing 
DataStream<->Table API interop. We should start advertising this new and very 
useful testing infra.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to