twalthr commented on code in PR #26893:
URL: https://github.com/apache/flink/pull/26893#discussion_r2270008810
##########
flink-table/flink-table-runtime/src/main/java/org/apache/flink/table/runtime/operators/deduplicate/utils/DeduplicateFunctionHelper.java:
##########
@@ -292,6 +292,20 @@ public static boolean shouldKeepCurrentRow(
}
}
+ private static boolean areRowsWithSameContent(
+ RecordEqualiser equaliser, RowData prevRow, RowData currentRow) {
+ final RowKind prevRowKind = prevRow.getRowKind();
+ final RowKind currentRowKind = currentRow.getRowKind();
+ if (prevRowKind == RowKind.INSERT && currentRowKind ==
RowKind.UPDATE_AFTER) {
Review Comment:
What happens if the prevRowKind was UPDATE_AFTER, is this possible? e.g. the
upsert Kafka emits +U,-D only
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
