Github user sunjincheng121 commented on a diff in the pull request:
https://github.com/apache/flink/pull/3046#discussion_r95315326
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/api/windows.scala
---
@@ -150,7 +147,7 @@ class TumblingWindow(size: Expression) extends
GroupWindow {
def as(alias: String): TumblingWindow =
as(ExpressionParser.parseExpression(alias))
override private[flink] def toLogicalWindow: LogicalWindow =
- ProcessingTimeTumblingGroupWindow(alias, size)
+ ProcessingTimeTumblingGroupWindow(name, size)
--- End diff --
Hi, @shaoxuan-wang thanks a lot for the review. I have updated the PR
according to your comments. The change list:
1. Remove GroupWindowedTable.
2. Chanage "name" to "alias".
3. Add testMultiWindow.
4. Rebase code and fixed the conflicts.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
