Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/3046#discussion_r96860442
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/api/table.scala
---
@@ -855,57 +858,45 @@ class GroupedTable(
val fieldExprs = ExpressionParser.parseExpressionList(fields)
select(fieldExprs: _*)
}
-
- /**
- * Groups the records of a table by assigning them to windows defined
by a time or row interval.
- *
- * For streaming tables of infinite size, grouping into windows is
required to define finite
- * groups on which group-based aggregates can be computed.
- *
- * For batch tables of finite size, windowing essentially provides
shortcuts for time-based
- * groupBy.
- *
- * @param groupWindow group-window that specifies how elements are
grouped.
- * @return A windowed table.
- */
- def window(groupWindow: GroupWindow): GroupWindowedTable = {
- new GroupWindowedTable(table, groupKey, groupWindow)
- }
}
-class GroupWindowedTable(
+class WindowGroupedTable(
private[flink] val table: Table,
private[flink] val groupKey: Seq[Expression],
- private[flink] val window: GroupWindow) {
+ private[flink] val window: Window) {
/**
- * Performs a selection operation on a windowed table. Similar to an
SQL SELECT statement.
+ * Performs a selection operation on a window grouped table. Similar to
an SQL SELECT statement.
* The field expressions can contain complex expressions and
aggregations.
*
* Example:
*
* {{{
- * groupWindowTable.select('key, 'window.start, 'value.avg + " The
average" as 'average)
+ * windowGroupedTable.select('key, 'window.start, 'value.avg + " The
average" as 'average)
* }}}
*/
def select(fields: Expression*): Table = {
+ // get group keys by removing window column
--- End diff --
window column -> window alias
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
