yuxiqian commented on PR #4101: URL: https://github.com/apache/flink-cdc/pull/4101#issuecomment-3284206575
> > Thanks for @loserwang1024's nice contribution, just left some comments. > > I wonder why we need to modify the public API in incremental API (adding the `Future<?>` thing), as changes in `StreamSplitReader#poolSplitRecords()` would suffice. Is it for the test purposes only? > > @yuxiqian remove future api now. Seems we can revert all changes in `SnapshotSplitReader` and `IncrementalSourceScanFetcher` now. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
