[
https://issues.apache.org/jira/browse/FLINK-5419?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15818318#comment-15818318
]
ASF GitHub Bot commented on FLINK-5419:
---------------------------------------
GitHub user zentol opened a pull request:
https://github.com/apache/flink/pull/3092
[FLINK-5419] Make full TM metrics available through REST API
This PR fixes the full set of TaskManager metrics not being available
through the REST API. The issue was that multiple handlers were registered for
the same URL ("/taskmanagers/:taskmanagerid/metrics").
The relevant handlers are the ```TaskManagersHandler``` which provides a
subset of metrics to the WebInterface (basically what is displayed in the
metrics tab in the TM page) and the ```TaskManagerMetricsHandler``` which
provides full access to metrics.
The issue was fixed by making the metrics tab use the following URL:
"/taskmanagers/:taskmanagerid". This is in fact a reversal of a previous
change, which technically changed a public API.
While fixing this i found a bug in the ```TaskManagerMetricsHandler```; it
used the wrong constant to extract the TaskManagerID from the path ("tmid"
instead of "taskmanagerid")
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/zentol/flink 5419_tm_rest
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/flink/pull/3092.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #3092
----
commit d88dc84100d6d53626c3cb13c5caff5a7bfacc55
Author: zentol <[email protected]>
Date: 2017-01-11T13:07:03Z
[FLINK-5419] Make full TM metrics available through REST API
----
> Taskmanager metrics not accessible via REST
> -------------------------------------------
>
> Key: FLINK-5419
> URL: https://issues.apache.org/jira/browse/FLINK-5419
> Project: Flink
> Issue Type: Bug
> Components: Metrics, Webfrontend
> Affects Versions: 1.2.0, 1.3.0
> Reporter: Chesnay Schepler
> Assignee: Chesnay Schepler
> Fix For: 1.2.0, 1.3.0
>
>
> There is currently a URL clash between the TaskManagersHandler and
> TaskManagerMetricsHandler, with both being routed to
> {code}
> /taskmanagers/:taskmanagerid/metrics
> {code}
> As a result it is not possible to query the full set of metrics for a
> taskmanager, but only the hard-coded subset that is displayed on the metrics
> tab on the taskmanager page.
> This is a side-effect of 6d53bbc4b92e651786ecc8c2c6dfeb8e450a16a3 making the
> URL's more consistent. The TaskManager page in the web-interface has 3 tabs:
> Metrics, Log and Stdout.
> The URLs for these tabs are
> {code}
> /taskmanager/<tmid>/metrics
> /taskmanager/<tmid>/log
> /taskmanager/<tmid>/stdout
> {code}
> which correspond to the REST URL's used. Previously, the metrics tab used
> {code}/taskmanager/<tmid>{code}
> However, 70704de0c82cbb7b143dd696221e11999feb3600 then exposed the metrics
> gathered by the metrics system through the REST API. The assumption was that
> general information for the taskmanagers are retrieved via
> /taskmanager/<tmid>, similar to how the job-related URL's are structured,
> which sadly isn't the case.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
