snuyanzin commented on code in PR #27079:
URL: https://github.com/apache/flink/pull/27079#discussion_r2413275518
##########
pom.xml:
##########
@@ -1204,6 +1204,41 @@ under the License.
</build>
</profile>
+ <profile>
+ <id>java25</id>
+ <activation>
+ <jdk>[25,)</jdk>
+ </activation>
+
+ <build>
+ <pluginManagement>
+ <plugins>
+ <plugin>
+
<groupId>org.apache.maven.plugins</groupId>
+
<artifactId>maven-surefire-plugin</artifactId>
+ <configuration>
+ <excludedGroups>
+
${surefire.excludedGroups.github-actions},
+
${surefire.excludedGroups.adaptive-scheduler},
+
${surefire.excludedGroups.jdk},
+
</excludedGroups>
+ </configuration>
+ </plugin>
+ <plugin>
+
<groupId>com.diffplug.spotless</groupId>
+
<artifactId>spotless-maven-plugin</artifactId>
+ <configuration>
+ <!-- Current
google format does not run on Java 25.
+ Don't
upgrade it in this profile because it formats code differently.
+
Re-evaluate once support for Java 11 is dropped. -->
+
<skip>true</skip>
+ </configuration>
+ </plugin>
Review Comment:
there is no compiler args for profile `java21`
you probably mean profile `java21-target` then it is different
there is a separate PR to add `java25-target` with such flags
https://github.com/apache/flink/pull/27080
this PR is only about disabling spotless
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
