davidradl commented on code in PR #27079:
URL: https://github.com/apache/flink/pull/27079#discussion_r2413253977


##########
pom.xml:
##########
@@ -1204,6 +1204,41 @@ under the License.
                        </build>
                </profile>
 
+               <profile>
+                       <id>java25</id>
+                       <activation>
+                               <jdk>[25,)</jdk>
+                       </activation>
+
+                       <build>
+                               <pluginManagement>
+                                       <plugins>
+                                               <plugin>
+                                                       
<groupId>org.apache.maven.plugins</groupId>
+                                                       
<artifactId>maven-surefire-plugin</artifactId>
+                                                       <configuration>
+                                                               <excludedGroups>
+                                                                       
${surefire.excludedGroups.github-actions},
+                                                                       
${surefire.excludedGroups.adaptive-scheduler},
+                                                                       
${surefire.excludedGroups.jdk},
+                                                               
</excludedGroups>
+                                                       </configuration>
+                                               </plugin>
+                                               <plugin>
+                                                       
<groupId>com.diffplug.spotless</groupId>
+                                                       
<artifactId>spotless-maven-plugin</artifactId>
+                                                       <configuration>
+                                                               <!-- Current 
google format does not run on Java 25.
+                                                                        Don't 
upgrade it in this profile because it formats code differently.
+                                                                        
Re-evaluate once support for Java 11 is dropped. -->
+                                                               
<skip>true</skip>
+                                                       </configuration>
+                                               </plugin>

Review Comment:
   I see that java 21 has compilerArgs, I am curious, is this missing for java 
25 or do we no longer need them at this level?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to