ctrlaltdilj commented on code in PR #27026: URL: https://github.com/apache/flink/pull/27026#discussion_r2441555483
########## flink-filesystems/flink-s3-fs-hadoop/src/main/java/org/apache/flink/fs/s3hadoop/FlinkS3AFileSystem.java: ########## @@ -0,0 +1,45 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.flink.fs.s3hadoop; + +import org.apache.flink.annotation.Internal; + +import org.apache.hadoop.fs.s3a.S3AFileSystem; +import software.amazon.awssdk.services.s3.S3Client; + +/** + * Extension of Hadoop's S3AFileSystem that exposes the S3Client for use in Flink's recoverable + * writers. + * + * <p>This class simply makes the protected {@link S3AFileSystem#getS3Client()} method public, + * avoiding the need to use internal S3A APIs. + */ +@Internal +public class FlinkS3AFileSystem extends S3AFileSystem { Review Comment: this is to address this comment https://github.com/apache/flink/pull/27026#discussion_r2423157113 @davidradl @Samrat002 let me how you would like to proceed -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
