Samrat002 commented on code in PR #27026: URL: https://github.com/apache/flink/pull/27026#discussion_r2426787526
########## flink-end-to-end-tests/flink-presto-s3-filesystem-test/pom.xml: ########## @@ -0,0 +1,94 @@ +<?xml version="1.0" encoding="UTF-8"?> Review Comment: Can you remove `flink-presto-s3-filesystem-test` ? ########## flink-filesystems/flink-s3-fs-hadoop/src/main/java/org/apache/flink/fs/s3hadoop/FlinkS3AFileSystem.java: ########## @@ -0,0 +1,45 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.flink.fs.s3hadoop; + +import org.apache.flink.annotation.Internal; + +import org.apache.hadoop.fs.s3a.S3AFileSystem; +import software.amazon.awssdk.services.s3.S3Client; + +/** + * Extension of Hadoop's S3AFileSystem that exposes the S3Client for use in Flink's recoverable + * writers. + * + * <p>This class simply makes the protected {@link S3AFileSystem#getS3Client()} method public, + * avoiding the need to use internal S3A APIs. + */ +@Internal +public class FlinkS3AFileSystem extends S3AFileSystem { Review Comment: S3A filesystem is not in the scope of this change . ########## flink-filesystems/flink-s3-fs-hadoop/src/main/java/org/apache/flink/fs/s3hadoop/HadoopS3AccessHelper.java: ########## @@ -139,27 +197,13 @@ public long getObject(String key, File targetLocation) throws IOException { } @Override - public ObjectMetadata getObjectMetadata(String key) throws IOException { + public FlinkObjectMetadata getObjectMetadata(String key) throws IOException { Review Comment: Any specific reason to change nomenclature ? ########## flink-filesystems/flink-s3-fs-base/src/main/java/org/apache/flink/fs/s3/common/model/FlinkPartETag.java: ########## @@ -0,0 +1,93 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.flink.fs.s3.common.model; + +import org.apache.flink.annotation.Internal; + +import java.io.Serializable; +import java.util.Objects; + +/** + * SDK-agnostic representation of a part uploaded in a multipart upload. + * + * <p>This class maintains compatibility with both AWS SDK v1 {@code PartETag} and AWS SDK v2 {@code + * CompletedPart}, allowing the base S3 filesystem implementation to work with either SDK version. + * + * <p>This class is serializable to support checkpoint recovery. The serialization format is + * independent of any AWS SDK version, ensuring backward compatibility across SDK upgrades. + */ +@Internal +public final class FlinkPartETag implements Serializable { Review Comment: Why are abstractions over S3 models required? ########## flink-end-to-end-tests/flink-presto-s3-filesystem-test/src/test/java/org/apache/flink/fs/s3presto/PrestoS3FileSystemMinioTest.java: ########## @@ -0,0 +1,233 @@ +/* Review Comment: Can you remove flink-s3-filesystem-test? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
