twalthr commented on code in PR #26926:
URL: https://github.com/apache/flink/pull/26926#discussion_r2387542965
##########
flink-table/flink-table-planner/src/main/java/org/apache/flink/table/planner/plan/nodes/physical/stream/StreamPhysicalMultiJoin.java:
##########
@@ -161,13 +164,25 @@ public RelWriter explainTerms(final RelWriter pw) {
for (final Ord<RelNode> ord : Ord.zip(inputs)) {
pw.input("input#" + ord.i, ord.e);
}
- return pw.item("joinFilter", joinFilter)
- .item("joinTypes", joinTypes)
- .item("joinConditions", joinConditions)
- .item("joinAttributeMap", joinAttributeMap)
- .itemIf("postJoinFilter", postJoinFilter, postJoinFilter !=
null)
+
+ return pw.item("commonJoinKey", getCommonJoinKeyFieldNames())
+ .item(
+ "joinTypes",
+ joinTypes.stream()
+ .map(JoinRelType::toString)
+ .collect(Collectors.joining(", ")))
+ .item("inputUniqueKeys", formatInputUniqueKeysWithFieldNames())
+ .item("joinConditions", formatJoinConditionsWithFieldNames(pw))
+ .itemIf(
Review Comment:
remove as it is contained in `joinConditions` already
##########
flink-table/flink-table-planner/src/test/resources/restore-tests/stream-exec-multi-join_1/three-way-left-outer-join-with-restore/plan/three-way-left-outer-join-with-restore.json:
##########
@@ -225,7 +225,7 @@
"priority" : 2
} ],
"outputType" : "ROW<`user_id` VARCHAR(2147483647), `name`
VARCHAR(2147483647), `user_id0` VARCHAR(2147483647), `order_id`
VARCHAR(2147483647), `user_id1` VARCHAR(2147483647), `payment_id`
VARCHAR(2147483647)>",
- "description" : "MultiJoin(joinFilter=[true], joinTypes=[[INNER, LEFT,
LEFT]], joinConditions=[[true, =($0, $2), =($0, $4)]],
joinAttributeMap=[{1=[LeftInputId:0;LeftFieldIndex:0;RightInputId:1;RightFieldIndex:0;],
2=[LeftInputId:0;LeftFieldIndex:0;RightInputId:2;RightFieldIndex:0;]}],
select=[user_id,name,user_id0,order_id,user_id1,payment_id],
rowType=[RecordType(VARCHAR(2147483647) user_id, VARCHAR(2147483647) name,
VARCHAR(2147483647) user_id0, VARCHAR(2147483647) order_id, VARCHAR(2147483647)
user_id1, VARCHAR(2147483647) payment_id)])"
+ "description" : "MultiJoin(commonJoinKey=[user_id], joinTypes=[INNER,
LEFT, LEFT], inputUniqueKeys=[noUniqueKey, noUniqueKey, noUniqueKey],
joinConditions=[true, (user_id = user_id0), (user_id = user_id1)],
joinFilter=[true], select=[user_id,name,user_id0,order_id,user_id1,payment_id],
outputRowType=[RecordType(VARCHAR(2147483647) user_id, VARCHAR(2147483647)
name, VARCHAR(2147483647) user_id0, VARCHAR(2147483647) order_id,
VARCHAR(2147483647) user_id1, VARCHAR(2147483647) payment_id)])"
Review Comment:
remove `joinFilter=[true]`
##########
flink-table/flink-table-planner/src/main/java/org/apache/flink/table/planner/plan/nodes/physical/stream/StreamPhysicalMultiJoin.java:
##########
@@ -161,13 +164,25 @@ public RelWriter explainTerms(final RelWriter pw) {
for (final Ord<RelNode> ord : Ord.zip(inputs)) {
pw.input("input#" + ord.i, ord.e);
}
- return pw.item("joinFilter", joinFilter)
- .item("joinTypes", joinTypes)
- .item("joinConditions", joinConditions)
- .item("joinAttributeMap", joinAttributeMap)
- .itemIf("postJoinFilter", postJoinFilter, postJoinFilter !=
null)
+
+ return pw.item("commonJoinKey", getCommonJoinKeyFieldNames())
+ .item(
+ "joinTypes",
+ joinTypes.stream()
+ .map(JoinRelType::toString)
+ .collect(Collectors.joining(", ")))
+ .item("inputUniqueKeys", formatInputUniqueKeysWithFieldNames())
+ .item("joinConditions", formatJoinConditionsWithFieldNames(pw))
+ .itemIf(
+ "joinFilter",
+ formatExpressionWithFieldNames(joinFilter, pw),
+ joinFilter != null)
+ .itemIf(
+ "postJoinFilter",
+ formatExpressionWithFieldNames(postJoinFilter, pw),
+ postJoinFilter != null)
.item("select", String.join(",", getRowType().getFieldNames()))
- .item("rowType", getRowType())
+ .item("outputRowType", getRowType())
Review Comment:
we should make sure that this is insync with other explains, I would suggest
to keep it `rowType`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
