davidradl commented on code in PR #27083:
URL: https://github.com/apache/flink/pull/27083#discussion_r2414396676


##########
flink-runtime/src/main/java/org/apache/flink/streaming/runtime/tasks/FinishedOnRestoreInput.java:
##########
@@ -30,6 +30,7 @@ public class FinishedOnRestoreInput<IN> implements Input<IN> {
     private final int inputCount;
 
     private int watermarksSeen = 0;
+    private int finishedStatusSeen = 0;

Review Comment:
   I am curious on you thinking on how this effects 
https://nightlies.apache.org/flink/flink-docs-master/docs/dev/datastream-v2/watermark/#emit-watermark
 customizations. 



##########
flink-runtime/src/main/java/org/apache/flink/streaming/runtime/tasks/FinishedOnRestoreInput.java:
##########
@@ -30,6 +30,7 @@ public class FinishedOnRestoreInput<IN> implements Input<IN> {
     private final int inputCount;
 
     private int watermarksSeen = 0;
+    private int finishedStatusSeen = 0;

Review Comment:
   I am curious on you thinking on how this new status effects 
https://nightlies.apache.org/flink/flink-docs-master/docs/dev/datastream-v2/watermark/#emit-watermark
 customizations. 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to