davidradl commented on code in PR #27083:
URL: https://github.com/apache/flink/pull/27083#discussion_r2414356023
##########
flink-runtime/src/main/java/org/apache/flink/streaming/runtime/tasks/StreamTask.java:
##########
@@ -746,6 +748,41 @@ private boolean isCurrentSyncSavepoint(long checkpointId) {
*/
protected void advanceToEndOfEventTime() throws Exception {}
+ /**
+ * Emits FINISHED watermark status to indicate this task has permanently
completed and should be
+ * excluded from watermark aggregation in downstream operators.
+ *
+ * <p>This method is overridden by source tasks to emit FINISHED status
directly to downstream
+ * via network outputs. Processing tasks (e.g., OneInputStreamTask,
TwoInputStreamTask) do not
+ * override this method because they rely on StatusWatermarkValve to
aggregate FINISHED status
+ * from upstream inputs and propagate it downstream automatically.
+ */
+ protected void emitFinishedStatus() {
Review Comment:
Can we arrange the class hierarchy so that emitFinishedStatus() is only
overridable for sources?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
