davidradl commented on code in PR #27160:
URL: https://github.com/apache/flink/pull/27160#discussion_r2469750274
##########
flink-state-backends/flink-statebackend-forst/src/main/java/org/apache/flink/state/forst/sync/ForStSyncKeyedStateBackend.java:
##########
@@ -938,7 +938,7 @@ public boolean
requiresLegacySynchronousTimerSnapshots(SnapshotType checkpointTy
@Override
public boolean isSafeToReuseKVState() {
- return true;
+ return !(priorityQueueFactory instanceof HeapPriorityQueueSetFactory);
Review Comment:
As this is set in the constructor - it would be better to do the instanceof
there and then set an instance field flag. At the moment we do the instanceof
every call of this method.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
