Zakelly commented on code in PR #27160:
URL: https://github.com/apache/flink/pull/27160#discussion_r2469829779
##########
flink-state-backends/flink-statebackend-forst/src/main/java/org/apache/flink/state/forst/sync/ForStSyncKeyedStateBackend.java:
##########
@@ -938,7 +938,7 @@ public boolean
requiresLegacySynchronousTimerSnapshots(SnapshotType checkpointTy
@Override
public boolean isSafeToReuseKVState() {
- return true;
+ return !(priorityQueueFactory instanceof HeapPriorityQueueSetFactory);
Review Comment:
If you read the code that invokes this method, you may find it only invoked
once when the subtask start. So don't worry about the performance. I'd prefer
keep this as it's more readable.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
